thenbrent
commented
12 years ago I would definitely review and most likely accept an OO version.
I'm going to do it myself in the near future though, simply due to time constraints. The original code base was written by another developer (as you'll see if you go way back in to commit logs) and I've taken to maintaining it ever since, despite many personal qualms I have with style, redundancy, improper use of or complete lack of use of WP API functions (WP_HTTP class for example would have been good to use).
So any time you put into OO'ing (is that even a verb? haha) the code base would be greatly appreciated, and I'll gladly add your WP Username as an author on the plugin if you invest that time. :)
On Wed, Nov 16, 2011 at 1:35 AM, Nathan Rijksen < reply@reply.github.com
wrote:
At the moment the plugin follows the wordpress coding style, which is based on where PHP was around version 3. And although it would take forever for Wordpress to be re-done on an OO style, plugins are a different story.
What I'm getting at is that this plugin in particular would benefit greatly from being re-done in an OO style, it's approaching a size where the Wordpress coding style just makes it feel a bit messy to maintain and that generally creates for a very error-prone coding environment. Of course we all have our own preferences and what works for one might not work for another.
So I'm simply wondering whether you would be willing to re-do this project in an OO style? And by re-do I basically just mean wrapping up the current codebase in an object oriented style, cause there's nothing wrong with the code as-is.
I'm mostly asking since I'm currently planning on doing just this, seeing as I plan to use this plugin for a large scale long-term project, I'd want a piece of code that's prone to being updated and played with often to be as accessible as possible.
Let me know whether you'd be open to doing this or be willing to review an OO approach of your codebase as a pull request later on.
Reply to this email directly or view it on GitHub: https://github.com/thenbrent/social-connect/issues/10
Naatan
DeanMarkTaylor
At the moment the plugin follows the wordpress coding style, which is based on where PHP was around version 3. And although it would take forever for Wordpress to be re-done on an OO style, plugins are a different story.
What I'm getting at is that this plugin in particular would benefit greatly from being re-done in an OO style, it's approaching a size where the Wordpress coding style just makes it feel a bit messy to maintain and that generally creates for a very error-prone coding environment. Of course we all have our own preferences and what works for one might not work for another.
So I'm simply wondering whether you would be willing to re-do this project in an OO style? And by re-do I basically just mean wrapping up the current codebase in an object oriented style, cause there's nothing wrong with the code as-is.
I'm mostly asking since I'm currently planning on doing just this, seeing as I plan to use this plugin for a large scale long-term project, I'd want a piece of code that's prone to being updated and played with often to be as accessible as possible.
Let me know whether you'd be open to doing this or be willing to review an OO approach of your codebase as a pull request later on.