thenbrent
commented
12 years ago That's epic and I'm going to need to set aside a good couple of hours for testing and review.
Don't worry about changing owner shit. As in the magic of git, I can easily fork/pull/push the repo. :)
On Fri, Dec 9, 2011 at 4:52 AM, Nathan Rijksen < reply@reply.github.com
wrote:
Tested & working, though only tested on one environment.
Be careful - if you push this to the wordpress plugin repo peoples existing configurations will break, seeing as auth providers are now their own plugin, they will have to download the providers they want and enable them for it to work. I'd suggest forking the plugin on the wordpress repo once the project has received significant enough updates in terms of features to justify pushing it to wordpress.
As for the plugin repo's it seems I have to contact github manually to change ownership by user, please let me know how you would like to proceed on that, do I have your approval to make that request?
You can merge this Pull Request by running:
git pull https://github.com/Naatan/social-connect master
Or you can view, comment on it, or merge it online at:
https://github.com/thenbrent/social-connect/pull/13
-- Commit Summary --
- Using the md5 hash of the user login is pointless as a workaround to find a suitable alternative faster, as it would always be the same if the username is already in use
- Converted plugin to object oriented structure, gateways have been made modular and act as their own plugins with a dependency on the social-connect plugin.
- Fixed indentation
- Don't need this anymore
- fixed indentation
- Removed non-functional features & streamlined provider terminology
- Added phpdoc
- Removed login form template, not worth it
- phpdoc cleanup
- don't need images anymore in the main plugin, they are now part of the individual provider plugins
-- File Changes --
D admin.php (118) A call.php (28) A classes/admin.php (53) A classes/auth.php (145) A classes/ui.php (63) A classes/utils.php (145) A classes/widget.php (114) D constants.php (8) D deploy.sh (77) R diagnostics.php (2) D facebook/callback.php (41) D facebook/facebook.php (959) D google/connect.php (45) D media.php (45) M media/css/style.css (34) M media/js/connect.js (103) D openid/connect.php (45) D openid/openid.php (706) M social-connect.php (434) D twitter/EpiCurl.php (128) D twitter/EpiOAuth.php (258) D twitter/EpiTwitter.php (118) D twitter/callback.php (42) D twitter/connect.php (18) D ui.php (192) D utils.php (35) D wordpress/connect.php (61) D yahoo/connect.php (45)
-- Patch Links --
https://github.com/thenbrent/social-connect/pull/13.patch https://github.com/thenbrent/social-connect/pull/13.diff
Reply to this email directly or view it on GitHub: https://github.com/thenbrent/social-connect/pull/13
Tested & working, though only tested on one environment.
Be careful - if you push this to the wordpress plugin repo peoples existing configurations will break, seeing as auth providers are now their own plugin, they will have to download the providers they want and enable them for it to work. I'd suggest forking the plugin on the wordpress repo once the project has received significant enough updates in terms of features to justify pushing it to wordpress.
As for the plugin repo's it seems I have to contact github manually to change ownership by user, please let me know how you would like to proceed on that, do I have your approval to make that request?