search

rodrigoprimo / social-connect

WordPress plugin for signup/login using social media providers.
http://wordpress.org/extend/plugins/social-connect/
GNU General Public License v3.0
73 stars 40 forks source link

Increased the cURL timeout to 200 for facebook request. #48

Closed ahmednasir91 closed 10 years ago

ahmednasir91 commented 10 years ago

I was getting "Operation timed out after 5117 milliseconds with 0 out of -1 bytes received social connect" for facebook connect, so I have increased the cURL timeout.

rodrigoprimo commented 10 years ago

This file is a library we use from the facebook-php-sdk project. Please send the pull request to that repository. If they release a new version please let me know and I will update the file used by Social Connect. Thanks for your contribution.

https://github.com/facebook/facebook-php-sdk/blob/master/src/facebook.php

ahmednasir91 commented 10 years ago

Newer version is out already v3.2.3 and we are using 2.0 - https://github.com/facebook/facebook-php-sdk

rodrigoprimo commented 10 years ago

Is there any improvement in this new version that might be useful for Social Connect? I'm not against updating but I prefer to focus on other areas if there is no reason to update.

ahmednasir91 commented 10 years ago

I would suggest updating to it, there are many other options added in the new API, I was trying the logout URL, it wasn't working. I think it will be good if the sdk is updated, may be the timeout error wont occur.

rodrigoprimo commented 10 years ago

I agree that it is a good idea to update anyway but I'm not sure when I will have time to do that.

If you can, please update, test and create a new pull request. Thanks!

rodrigoprimo commented 10 years ago

The facebook-php-sdk has been updated to the latest version in the commit 9a052cf and will be in the next release. I'm closing this PR. Feel free to open another PR or issue if the timeout error still occurs.