Finish the exercise - Githubissues

nasivuela commented 5 years ago

Really cool job @rodriguezmontesinoseva !!!

Here you have some tips to improve the exercise:

[ ] Fix the language and the meta title of the page
[x] Be extra careful with syntax, it looks like you have errors when closing lis and as
[x] We need a nav and an h1 tags
[x] Logo should be clickable
[x] Move the font CSS before your main CSS
[x] You are using a selector .body (class) that do not exist on HTML, did you mean body (tag)?
[x] Improve hierarchy adding more common styles to body tag as font-size, font-family, font-weight, color, background-color
[x] Fix the header to the viewport
[ ] Main title should be vertically and horizontally centered (should we use Flex to achieve this?)
[ ] Avoid uppercase on HTML texts, we can transform the text with CSS; this way we keep concepts separated, HTML for content, and CSS for styles
[ ] Finish the main title styles: words should jump and the typography is bolder
[x] Remove commented CSS rules
[x] Indent and avoid extra white spaces to improve readability and avoid bugs
[x] Try to use imperative for your commit messages. Ex. - > Fix central text
[x] Organize your files in folders, you have a guide to help you with that here --> https://books.adalab.es/materiales-front-end-f/modulo-1.-hola-mundo/1_1_intro_a_la_web#notas-finales-sobre-como-organizar-nuestro-proyecto

Once you have these fixed try to finish the styles for the tablet.

Let me know if you have any doubts ;)

Go for it!!

rodriguezmontesinoseva commented 5 years ago

The exercise is finished. I did it again from the beginning to understand it better. I've included all the tips you give me and I've added the styles for tablet. Thanks for your corrections :)

nasivuela commented 5 years ago

@rodriguezmontesinoseva Be careful with the routes, they should be relatives, not absolutes. That will fix the errors on Github Pages.

rodriguezmontesinoseva commented 5 years ago

it's not clear to me what the relative routes are, how should I indicate them? I think the routes I have indicated in the code are relative :-/

nasivuela commented 5 years ago

Absolute routes start with a / and when you use them you are indicating that the route starts at the top of your site.

So when you write /styles/main.css on index.html, and put your page on the Github Pages domain http://beta.adalab.es/f-m1-evaluacion-intermedia-rodriguezmontesinoseva/, you are telling that the CSS is on http://beta.adalab.es/styles/main.css. You can see it clearly at the 'Network' tab of the inspector of Chrome.

Relatives routes do start without / or with ./, ../ and this way you indicate that the route is relative to the file where you are witting it.

So when you write styles/main.css on index.html, the domain doesn't matter. And you are telling that the CSS is in a folder 'styles' that is located at the same level that index.html.

rodriguezmontesinoseva commented 5 years ago

Okay, I think I got it, I'm gonna change it. Thank you Nasiba

rodriguezmontesinoseva / f-m1-evaluacion-intermedia-rodriguezmontesinoseva

Finish the exercise #1