rodydavis / navigation_rail

Navigation Rail for Flutter
https://rodydavis.github.io/navigation_rail/
MIT License
49 stars 11 forks source link

Enchancement: backdropMode #3

Closed seanaguinaga closed 1 month ago

seanaguinaga commented 4 years ago

First of all, thank you again for making this.

I'm not sure how customizable you want this to be out of the box of if you'd want to support every possible permutation possible/modes mentioned in the docs by default or if you'd want this to make it into Flutters Widget library itself?

To get close the effect below, I had to modify your source files a bit: colors for the rail in a tablet media query size.

image

Are you open to pull requests adding all of the permutations mentioned in the docs/support for custom or inherited theming for all of these permutations/accessibility features, etc..?

https://github.com/flutter/flutter/pull/49574

I saw this earlier (just saw you replied)

Eventual goal to maybe submit it as a Material Widget once all bases and things are covered?

Thoughts?

rodydavis commented 4 years ago

I’m open to PRs! I can see if there is a way to make a mode in the constructor. Like Switch and Switch.adaptive, completely different behavior and look but same widget.

Where does this spec/design come from?

seanaguinaga commented 4 years ago

Okay! Cool!

The material guidelines page: https://material.io/components/navigation-rail/#behavior

Good thinking! (Switch idea)

On Feb 1, 2020, at 10:29, Rody Davis notifications@github.com wrote:

 I’m open to PRs! I can see if there is a way to make a mode in the constructor. Like Switch and Switch.adaptive, completely different behavior and look but same widget.

Where does this spec/design come from?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.