search

roed314 / OMS

Converting Rob Pollack's overconvergent modular symbols .sage code to .py and putting it in Sage
4 stars 4 forks source link

Why does Symk ignore dettwist? #37

Closed mmasdeu closed 11 years ago

mmasdeu commented 11 years ago

I pulled an hour ago and everything I had working with Sigma0 broke. I saw several changes in the interface, to which I adapted, but then I realize that now dettwist is deactivated for Symk, and I do need a twist... Is there a good reason for that?

loefflerd commented 11 years ago

Pure sloppiness, sorry! Originally the code did some weird confusing thing where the character was sometimes stored as a character and sometimes as a pair (character, integer). I changed the interface to get rid of that but I forgot to check dettwist worked for symk. My bus leaves in an hour, I can probably fix it before then...

mmasdeu commented 11 years ago

I made it work by changing the init of Distributions_abstract as follows:

    if self.base_ring().is_exact() and (self.is_symk() or character is not None):
        self._act = WeightKAction(self, character, adjuster, act_on_left, dettwist)
    else: 
        self._act = WeightKAction(self, character, adjuster, act_on_left, dettwist, padic=True)

If that seems right to you, I'll just push the changes... But let me know if you'd rather do it!

mmasdeu commented 11 years ago

(I mean other than passing dettwist regardless of the type of distribution...