Closed dhdaines closed 3 months ago
CLI load time: 0:00.05
PR head c879f9bc96cca03fbe6b86ea9f687499e30034c2
Imports that take more than 0.1 s:
import time: self [us] | cumulative | imported package
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 93.72%. Comparing base (
b772bd6
) to head (c879f9b
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I can't judge the mapping itself, except for the fact that it looks a lot like some of our other APA-based mappings, but this PR looks good to me in every way I can fairly assess it.
Thanks - I will actually withdraw this for the moment while I make sure that it's okay to release it!
Pull request template for adding a new language
Do not use this for other types of pull requests
Please check if the PR fulfills these requirements
[x] Mapping files are added in
g2p/mappings/langs
[x] Mapping is either added to an existing folder or a new folder has been added
[x] Language folder and files use appropriate ISO 639-3 codes
[x]
config-g2p.yaml
file includes all author names, and settings necessary[x] Please add some test data in
g2p/tests/public/data
. The added file should be a csv/tsv/psv file and each row should have the format[input_mapping_code,output_mapping_code,input_string,output_string]
[x] As the last step, G2P has been updated by running
g2p update
locally and committing the change[x] You agree to license your contribution under the same license as this project (see LICENSE file).
Other information:
Based on the official desktop keyboard layout (https://makahmuseum.com/makah-keyboard/) from the Makah Language Program (https://makahmuseum.com/departments/makah-language-program/)
Note that we also accept the orthgraphy from Davidson 2002 (which is really Nuuchahnulth) - differences from the standard orthography are: