roedoejet / g2p

Grapheme-to-Phoneme transductions that preserve input and output indices, and support cross-lingual g2p!
https://g2p-studio.herokuapp.com
Other
119 stars 26 forks source link

Add mapping for Makah #355

Closed dhdaines closed 3 months ago

dhdaines commented 3 months ago

Pull request template for adding a new language

Do not use this for other types of pull requests

Based on the official desktop keyboard layout (https://makahmuseum.com/makah-keyboard/) from the Makah Language Program (https://makahmuseum.com/departments/makah-language-program/)

Note that we also accept the orthgraphy from Davidson 2002 (which is really Nuuchahnulth) - differences from the standard orthography are:

github-actions[bot] commented 3 months ago
CLI load time: 0:00.05
PR head c879f9bc96cca03fbe6b86ea9f687499e30034c2
Imports that take more than 0.1 s:
import time: self [us] | cumulative | imported package
codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 93.72%. Comparing base (b772bd6) to head (c879f9b).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #355 +/- ## ========================================== + Coverage 93.59% 93.72% +0.12% ========================================== Files 18 18 Lines 2342 2342 Branches 520 520 ========================================== + Hits 2192 2195 +3 + Misses 85 83 -2 + Partials 65 64 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

dhdaines commented 3 months ago

I can't judge the mapping itself, except for the fact that it looks a lot like some of our other APA-based mappings, but this PR looks good to me in every way I can fairly assess it.

Thanks - I will actually withdraw this for the moment while I make sure that it's okay to release it!