roedoejet / g2p

Grapheme-to-Phoneme transductions that preserve input and output indices, and support cross-lingual g2p!
https://g2p-studio.herokuapp.com
Other
128 stars 27 forks source link

fix: make the g2p library tests still run on Python 3.7 #363

Closed joanise closed 5 months ago

joanise commented 5 months ago

All production API code, and API testing code, requires Python 3.7, but the base g2p CLI and library module still support Python 3.7 and need to be testing in CI.

@dhdaines This PR on top of #360 would fix my concerns regarding exercising g2p library tests with Python 3.7

github-actions[bot] commented 5 months ago
CLI load time: 0:00.05
PR head d5d20864dbf7534600b4063842577846749c01c4
Imports that take more than 0.1 s:
import time: self [us] | cumulative | imported package
codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 77.14286% with 16 lines in your changes are missing coverage. Please review.

:exclamation: No coverage uploaded for pull request base (dev.fastapi@f4683a9). Click here to learn what that means.

:exclamation: Current head 054a8e4 differs from pull request most recent head d5d2086. Consider uploading reports for the commit d5d2086 to get more accurate results

Files Patch % Lines
g2p/app.py 62.85% 13 Missing :warning:
g2p/api.py 91.17% 2 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev.fastapi #363 +/- ## ============================================== Coverage ? 90.52% ============================================== Files ? 17 Lines ? 2302 Branches ? 520 ============================================== Hits ? 2084 Misses ? 155 Partials ? 63 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.