A couple of Studio fixes

dhdaines commented 2 months ago

One rather important one - we definitely do not need to send CORS from the Studio app to accept all origins, this was a (bad) leftover from some example code. Studio is definitely same-origin and should always be.

One less important one - if you delete all the input, the last character sticks around. It isn't a problem to request conversion of an empty string so we should allow it to happen.

Also add the G2P_STUDIO_DEBUG environment variable which prints out all the socket.io messages, very useful for debugging.

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 83.33333% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 93.33%. Comparing base (b071222) to head (2ca3735).

Files	Patch %	Lines
g2p/app.py	83.33%	0 Missing and 1 partial :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## dev.ej/gitlint-core #370 +/- ## ======================================================= - Coverage 93.36% 93.33% -0.04% ======================================================= Files 17 17 Lines 2427 2431 +4 Branches 542 543 +1 ======================================================= + Hits 2266 2269 +3 Misses 92 92 - Partials 69 70 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 2 months ago

CLI load time: 0:00.05
PR head 2ca3735fc3681aec5128b43b2a1e9e7a6a7a8889
Imports that take more than 0.1 s:
import time: self [us] | cumulative | imported package

roedoejet / g2p

A couple of Studio fixes #370

Codecov Report