feat: add logic to auto-delete as_is support in g2p 3

joanise commented 1 month ago

PR Goal?

as_is has been deprecated for a long time, but we didn't declare when it would be removed. Let this be that declaration.

Fixes?

Fixes #374

Feedback sought?

sanity check

Priority?

low

Tests added?

was already tested

How to test?

If you want to see it fail, change version_tuple < (3,): to < (2,), that will make the as_is unit test fail now, which should get deleted when we release 3.

Confidence?

high

Version change?

no

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 33.33333% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 93.18%. Comparing base (fd27160) to head (d14dcf4).

Files	Patch %	Lines
g2p/mappings/__init__.py	33.33%	3 Missing and 1 partial :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #381 +/- ## ========================================== - Coverage 93.33% 93.18% -0.15% ========================================== Files 17 17 Lines 2431 2437 +6 Branches 543 544 +1 ========================================== + Hits 2269 2271 +2 - Misses 92 95 +3 - Partials 70 71 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 1 month ago

CLI load time: 0:00.05
PR head d14dcf4ee3986a2a029b6262d275aca09ce29921
Imports that take more than 0.1 s:
import time: self [us] | cumulative | imported package

roedoejet / g2p