search

roehling / postsrsd

Postfix Sender Rewriting Scheme daemon
319 stars 38 forks source link

Don't try to rewrite recipients that aren't our SRS domain #124

Closed jeredfloyd closed 2 years ago

jeredfloyd commented 2 years ago

Trying to rewrite recipients that aren't from our SRS domain will almost certainly fail (because the hash and/or timestamp won't match), but we really ought not try to begin with.

roehling commented 2 years ago

I don't think this is a good idea. The check is not particularly expensive, and if someone migrated their SRS domain, they would needlessly invalidate addresses.

jeredfloyd commented 2 years ago

Would you entertain this as a boolean option?

roehling commented 2 years ago

Do you have a particular use-case in mind?

jeredfloyd commented 2 years ago

Hm... no, I guess not; just a dislike for logging of failed checksums for foreign SRS, but that is very rare. Nevermind this PR.