Closed su-v closed 8 years ago
I'd be happy to provide dummy files. Do you have any special need or request? Do you need many? I guess a multilayer one. But what else?
No special requests - whatever makes sense to test the features of inklingreader.
Random files I used for tests so far (downloaded from related issues here on github, and found elsewhere on the web): https://www.dropbox.com/sh/l582s0bgvfnywit/UICcEjraCJ (one of them has multiple layers: SKETCH23.WPI)
Maybe it's a great moment to start making unit tests. It will make it more difficult for me to break your InklingReader experience ;-).
I haven't used any unit testing libraries in C.. It might be most easy to write something myself..
Xuv wrote:
I guess a multilayer one. But what else?
From the README file:
Automatically use different colors when the "new layer" is pressed multiple times.
This is one of the inklingreader features I didn't figure out how to test yet: none of the WPI files I found render with multiple colors, even the one with 3 layers (SKETCH23.WPI).
@su-v
This is one of the inklingreader features I didn't figure out how to test yet: none of the WPI files I found render with multiple colors, even the one with 3 layers (SKETCH23.WPI).
Press the "new layer" button twice without using the pen in the meantime. When multiple colors are set everything written after pressing the "new layer" button twice will be displayed in the second color.
@roelj
Press the "new layer" button twice without using the pen in the meantime. When multiple colors are set everything written after pressing the "new layer" button twice will be displayed in the second color.
I don't have the hardware to generate WPI files myself ;-) ... (see original description of this issue).
@su-v : I have the hardware, so I'll generate a file for you. I thought you needed something to include with an Inkscape plugin. So I was thinking of making a better drawing than just lines. But I can do a simple test with layers. @roelj: I'm surprised that I have to click the "new layer" button twice. The default behavior of the Inkling, as stated in the Wacom documentation, says "press once" for new layer. That's why I could not make this "multicolored layer" feature work either. Why do we have to press twice?
@xuv
I'm surprised that I have to click the "new layer" button twice. The default behavior of the Inkling, as stated in the Wacom documentation, says "press once" for new layer. That's why I could not make this "multicolored layer" feature work either. Why do we have to press twice?
Pressing once will create a new layer, but won't change the color. Changing colors isn't a feature in the original Inkling software, it's something I came up with.
Basically, every time the "new layer" button is pressed, a NEW_LAYER data block is created. When InklingReader sees multiple NEW_LAYER blocks after each other without any data between it, it'll pick the next color. So pressing three times will select the third color, four times the forth color and so on..
@xuv wrote:
@su-v : I have the hardware, so I'll generate a file for you. I thought you needed something to include with an Inkscape plugin. So I was thinking of making a better drawing than just lines. But I can do a simple test with layers.
The test files I was asking for are mainly to test the local builds of inklingreader (on OS X). If that works ok, basic import in Inkscape can be done quite easily - a sample WPI input extension is here [*]:
https://gist.github.com/su-v/11371965
(On linux, make sure that the python script is exectuable, and that inklingreader
is in $PATH
)
[*] The extension in the gist is just a quick hack and only briefly tested. Likely it should not be difficult to add a dialog with inklingreader options (background / foreground colors, pressure-factor).
Here's a sample with multiple colors: SKETCH82.WPI.
@su-v: I'll give a try to that inkscape extension. Thx.
@roelj: It's kind of a 'hack' this double/triple click to create color layers. And I find it weird to create empty layers just to achieve this. I understand that your intention is to mimic the original Wacom software, but I'm not sure this is the best way to go. I finally took the time to install the Wacom official program on Windows and although it has some features that InklingReader doesn't have, InklingReader looks way more clean and lean than the official one. So trying absolutely to 'clone' the official app is maybe not a good idea, IMHO. A second argument against the 'double, triple click' for color layers is that if you open these same files in the official Wacom software, you would have a lot of empty layers hanging here and there. And that would not make much sense. To me, the "color each layer" feature you added is a good idea, but doesn't need a hack to be performed. Maybe this feature could be set up in a different way. The official app has a layer viewer on the side of the window. When you roll over one layer preview thumb, it displays that layer in a different color in the main window. Not sure we have to got that way, but coloring each layer in a side bar would be a closer to the behavior of the official app. Just a suggestion.
@xuv: It is a hack indeed. Fortunately it doesn't get in the way of any other use-case scenario. I'm making a few other changes to the GUI as well, so I'll see if I can fit in a layer viewer as well.
@su-v: Your Inkscape extension works fine for me. Are you interested in adding it to this project and develop it further (having some configuration options within Inkscape would be cool)?
@roelj :
Your Inkscape extension works fine for me. Are you interested in adding it to this project and develop it further (having some configuration options within Inkscape would be cool)?
Yes, I'd be interested to add more options to the input extension. Since my git skills haven't improved a lot (I'm more familiar with bzr, since that's what Inkscape uses), would it be ok if I'll update the one in the gist for now, and let you know about any progress? Once the main features are in, you then could copy it to the inklingreader repo …
@su-v:
Yes, I'd be interested to add more options to the input extension. Since my git skills haven't improved a lot (I'm more familiar with bzr, since that's what Inkscape uses), would it be ok if I'll update the one in the gist for now, and let you know about any progress? Once the main features are in, you then could copy it to the inklingreader repo …
That's OK too. However, it's really simple to add it to the repo:
git clone https://github.com/roelj/inklingreader.git
git add res/wpi2svg-ext.py res/wpi_input.inx
git commit -m "Added the Inkscape extension."
git push
Updating it later is also rather easy:
git pull
git add res/wpi2svg-ext.py res/wpi_input.inx
git commit -m "Your message about the changes."
git push
If it's too much of a hassle, having it in the gist is fine for now. It would be cool if we could some day package it all together.
Closing - test files as originally requested had been provided (see links in earlier comments).
To ease testing this new tool on other platforms, it would be helpful to have a couple of test files available (original WPI, and all supported export formats (SVG, PNG, PDF)).
(Background of this request: personally, I don't own a Wacom Inkling - my interest is mostly driven by Inkscape users asking for available solutions to edit Inkling files in Inkscape. Possibly inklingreader (CLI) could be used via input extension (similar to how input of PS/EPS (via ps2pdf) currently is implemented, or other file formats supported via UniConvertor 1.1.5), so that for editing, WPI files could be opened as SVG files directly from Inkscape (if inklingreader is installed and found in $PATH)).