search

roelmann / moodle-theme_waxed

Moodle-theme_waxed: GitHub is now a mirror repository only. Please post issues at https://gitlab.com/roelmann/moodle-theme_waxed/issues
10 stars 1 forks source link

Plugins bot code checker fixes #7

Closed roelmann closed 6 years ago

roelmann commented 7 years ago

https://integration.moodle.org/job/Precheck%20remote%20branch/31953/artifact/work/smurf.html

Prechecker results: error (3599 errors/92 warnings) => phplint (0/0), phpcs (3/0), js (0/0), css (3547/89), phpdoc (48/0), savepoint (0/0), thirdparty (0/0), grunt (1/1), shifter (0/0), mustache (0/2),

roelmann commented 7 years ago

PHP coding style problems (3 errors, 0 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

theme/waxed/classes/autoprefixer.php (#117) Protected method name "autoprefixer::manipulateRuleValues" must be in lower-case letters only (#161) Protected method name "autoprefixer::processBlock" must be in lower-case letters only (#197) Protected method name "autoprefixer::processDeclaration" must be in lower-case letters only

These are upstream errors from Boost autoprefixer Done - CARE if updating in the future, code from Boost will override again.

roelmann commented 7 years ago

CSS problems (3547 errors, 89 warnings) This section shows CSS problems detected by stylelint

These are largely from the pre-processed preset files generated from the CLI script in Boost.

Bootswatch presets - will not fix. These are as processed by the Boost CLI script from the bootswatch project - need to be able to reference back to bootswatch files. These files should be excluded from any Travis or code checker processes. Other scss files - fixed

roelmann commented 7 years ago

Passes local-codechecker and Travis

roelmann commented 7 years ago

Adding thirdpartylibs.xml to cover the bootswatch presets https://github.com/roelmann/moodle-theme_waxed/commit/8ca6e8dbe340c18d217760bf8aa47105ebcf0ecd

roelmann commented 7 years ago

default.scss modified to match pluginbot coding standards - although this is initially a clone of the Cerulean bootswatch preset, it makes sense for this file to not be included in the thirdpartylibs.xml, and therefore to force it to follow coding standards, because this is the theme default preset and the one that can/will be edited and adapted if any default changes are required in the theme look and feel. It could therefore move away from Cerulean over time.

roelmann commented 7 years ago

https://github.com/roelmann/moodle-theme_waxed/commit/d48e1725f200c0744c3b1e9e3b14342a47528a5e

roelmann commented 7 years ago

Most issues cleared by rewrite, still about half-dozen phpdocs issues to resolve

roelmann commented 6 years ago

Superceded by new version