search

roelvandijk / numerals

Convert numbers to number words
Other
25 stars 15 forks source link

Bulgarian cardinals #3

Closed rycee closed 12 years ago

rycee commented 12 years ago

I have added a module for Bulgarian cardinals under a million. I'm just a learner of the language but I believe it is correct (my native speaking girlfriend helped me out a bit).

Note, there is some degree of cargo-culting going on in the code so please look it over for any silliness.

roelvandijk commented 12 years ago

Thank you! I'm very happy that you managed to add a new language.

If there are parts of the code/framework that could be made clearer I'd like to know. Some of it may be a bit obscure (thinking of the support for big numbers). I could write more documentation if I knew where it would be needed most.

Note, there is some degree of cargo-culting going on in the code so please look it over for any silliness.

I found no traces of silliness in the code :-).

rycee commented 12 years ago

I'm glad you liked it and that you didn't find any major flaws. It was actually rather uncomplicated to add the support for Bulgarian, the trickiest part for me was to wrap my brain around the problem of how the expressions represent the way we write the numerals and how the contexts work. But I must say that you implemented this library in an elegant way and just thinking about the problem logically led me on the right path.

I'll probably give big numbers in Bulgarian a try and will let you know if (or when) I run into trouble.