Use context manager for editing file

roest01 / docker-speedtest-analyser

Automated docker speedtest analyser tool with included web interface to monitor your internet speed connection over time. Setup at home on your NAS (Synology, QNAP tested) and the container runs hourly speedtests. The speedtest results are displayed in an webinterface as line graph(s) over the day.

Other

108 stars 47 forks source link

Use context manager for editing file #48

Closed owenleonard closed 3 years ago

owenleonard commented 4 years ago

standardize how the filepath is constructed
use a context manager for opening and editing the file so it is closed automatically
open file with a+ so it will create the file if it doesn't exist, and append to the file if it does exist

owenleonard commented 4 years ago

outfile.tell() isn't behaving the same in the container, so this isn't working properly. I need to figure that out.

roest01 commented 3 years ago

Hey @owenleonard, Thanks for the update. As your branch need some review cause auf conflicts and you've written that it's not working properly i am not going to solve this conflict myself. Do you want to rewrite the branch on current develop ?

owenleonard commented 3 years ago

I just looked at the changes in this branch and what is on master and the important changes are already there. Closing this PR as not needed.