Closed davidanthoff closed 6 years ago
Merging #14 into master will increase coverage by
2.31%
. The diff coverage is56.81%
.
@@ Coverage Diff @@
## master #14 +/- ##
=========================================
+ Coverage 79.89% 82.2% +2.31%
=========================================
Files 8 8
Lines 373 399 +26
=========================================
+ Hits 298 328 +30
+ Misses 75 71 -4
Impacted Files | Coverage Δ | |
---|---|---|
src/libc.jl | 63.33% <ø> (+13.33%) |
:arrow_up: |
src/FilePaths.jl | 28.57% <0%> (-4.77%) |
:arrow_down: |
src/posix.jl | 61.53% <0%> (-2.47%) |
:arrow_down: |
src/path.jl | 87.09% <50%> (-1.17%) |
:arrow_down: |
src/windows.jl | 67.56% <62.5%> (+67.56%) |
:arrow_up: |
src/mode.jl | 92.75% <0%> (-1.45%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 26d23de...923149f. Read the comment docs.
I have a follow up PR to this one that fixes lots of julia 0.6 deprecations, but I'll open that once this one here is merged.
Alright, this looks good to merge. Thanks @davidanthoff!
Cool. Maybe tag a version? Then I can start to use it in various packages and see how it goes. I'm pretty sure this will need a couple of iterations to iron out all the issues...
Sounds good. https://github.com/JuliaLang/METADATA.jl/pull/13436
Fixes #12, fixes #8.
I think this is ready now. I'm pretty sure there are still corner cases that it doesn't handle correctly, but for now tests pass and it seems easier to fix these as we go along.
I dropped julia 0.5 support, hope that is ok.