search

rofinn / FilePaths.jl

A type based approach to working with filesystem paths in julia
Other
82 stars 14 forks source link

Fix a WindowsPath constructor #21

Closed davidanthoff closed 6 years ago

davidanthoff commented 6 years ago

I'll add tests once I've seen code coverage results for this.

codecov-io commented 6 years ago

Codecov Report

Merging #21 into master will increase coverage by 0.3%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #21     +/-   ##
=========================================
+ Coverage    82.2%   82.51%   +0.3%     
=========================================
  Files           8        8             
  Lines         399      406      +7     
=========================================
+ Hits          328      335      +7     
  Misses         71       71
Impacted Files Coverage Δ
src/windows.jl 72.72% <100%> (+5.15%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a480e3c...e0b9004. Read the comment docs.

davidanthoff commented 6 years ago

@rofinn Alright, this is ready to be reviewed and merged.

rofinn commented 6 years ago

LGTM. I forgot about that splitdrive regex :(

davidanthoff commented 6 years ago

Yeah, I think the fact that the base function actually behaves differently depending on where you run it is quite problematic.