search

roflmuffin / CounterStrikeSharp

CounterStrikeSharp allows you to write server plugins in C# for Counter-Strike 2/Source2/CS2
https://docs.cssharp.dev
Other
742 stars 111 forks source link

Collision Group consts define is wrong. #375

Closed chenbuyi2019 closed 5 months ago

chenbuyi2019 commented 5 months ago

css define is different from alliedmodders/hl2sdk cs2 enum Collision_Group_t.
i think the hl2sdk cs2 one would be correct.
I was thinking why I set a prop to WEAPON and it still collides to player.
Turns out, it was the wrong number. COLLISION_GROUP_WEAPON shall be 14 not 11.
COLLISION_GROUP_PUSHAWAY shall be 20 not 17.

chenbuyi2019 commented 5 months ago

and some test result of mine : https://buyi.dev/2024/cs2-collisiongroup/

roflmuffin commented 5 months ago

Thanks for the report, would you be able to test using the generated API artifact from this PRs latest build and re-run your tests. I've updated the enum to the same as hl2sdk

https://github.com/roflmuffin/CounterStrikeSharp/pull/376

chenbuyi2019 commented 5 months ago

image it is now ok and good.