search

roflmuffin / CounterStrikeSharp

CounterStrikeSharp allows you to write server plugins in C# for Counter-Strike 2/Source2/CS2
https://docs.cssharp.dev
Other
742 stars 111 forks source link

Fix backwards compatibility in DynamicHook #388

Closed ipsvn closed 5 months ago

ipsvn commented 5 months ago

Re-add the unused parameter with a overload because it breaks plugins not updated to also remove said parameter

partiusfabaa commented 5 months ago

Then why was it necessary to accept this PR(#334)? So many plugins where GetReturn with an index is used?

B3none commented 5 months ago

Then why was it necessary to accept this PR(#334)? So many plugins where GetReturn with an index is used?

It’s about maintaining backwards compatibility, as far as I’m aware your PR shouldn’t have been merged without adding this change

ipsvn commented 5 months ago

Then why was it necessary to accept this PR(#334)? So many plugins where GetReturn with an index is used?

I don't believe that many, so it isn't a massive issue, but it would've been nice if this was included in the original PR to give some time before it was removed completely and just breaking any existing plugins using it. Anyone using it has probably fixed it by now though, so it's probably not that important. ¯\_(ツ)_/¯