CenterHtmlMenu Open method in a weird state.

roflmuffin / CounterStrikeSharp

CounterStrikeSharp allows you to write server plugins in C# for Counter-Strike 2/Source2/CS2

https://docs.cssharp.dev

Other

741 stars 111 forks source link

Closed frederikstonge closed 4 months ago

frederikstonge commented 4 months ago

Not really an issue, but something is missing here in the new CenterHtmlMenu change to support Open method.

IMO, we should either remove the constructor without the BasePlugin :

OR, throw an exception if the BasePlugin is null to inform the user that he has used the wrong constructor :

roflmuffin commented 4 months ago

I agree, I almost requested this as a CR in the PR but decided against it but I think throwing the exception makes sense