Make signature support IDA/x64Dbg style

roflmuffin / CounterStrikeSharp

CounterStrikeSharp allows you to write server plugins in C# for Counter-Strike 2/Source2/CS2

https://docs.cssharp.dev

Other

741 stars 111 forks source link

Make signature support IDA/x64Dbg style #407

Closed Nukoooo closed 4 months ago

Nukoooo commented 4 months ago

See discussion for more info.

TLDR: Make developers' life easier so they don't have to convert their signatures(48 8B ?) to code style(\x48\x8B\x2A) every time when they make a signature

What's changed

Signature now supports IDA/x64Dbg style (48 8B ? ? ? ? ?)
Removed duplicated code
Switched to C++20 (because of std::views::split)
FindSignature now uses std::find and std::equal for better readability

roflmuffin commented 4 months ago

LGTM, what platforms have you tested this on?

Nukoooo commented 4 months ago

I only tested on Windows. but I also tried to compile with GCC 13.2.1 and Clang 17.0.6 on my Arch WSL, while GCC ccompiled successfully without any error, clang required to remove register keywords in hl2sdk-cs2/tier1/generichash.cpp to make it work

Nukoooo commented 4 months ago

Just took a look at why the build failed on linux, it turned out std::string_view(split.begin(), split.end()) only exists in GCC 12.1 and above and Clang 16.0.0 and above see here. So it might need to upgrade the compiler that workflow uses newer compiler.

roflmuffin commented 4 months ago

Tested on Linux using latest build artifact ✅