roflmuffin / CounterStrikeSharp

CounterStrikeSharp allows you to write server plugins in C# for Counter-Strike 2/Source2/CS2
https://docs.cssharp.dev
Other
778 stars 125 forks source link

Make shared type loader less strict #424

Closed KillStr3aK closed 5 months ago

KillStr3aK commented 5 months ago

I propose this change as I don't think we should be this strict when we are loading shared types. Currently when a shared type is loaded it is saved with assembly build version and plugins that depends on other shared type(s) cannot be loaded if the shared type version has changed, even if there are no breaking changes as the shared type just cannot be found at all (or version mismatch)

this pr changes this behaviour and it only looks for the shared type name and loads it, I believe developers should be aware of the changes of the shared type they depend on, just like how it works with the core api.

KillStr3aK commented 5 months ago

(this has been tested and works as intended without breaking anything, also keep in mind that we can't even have the same assembly with different versions on the server)