search

rog-golang-buddies / golang-template-repository

Kickstarter repository for a golang service
Apache License 2.0
17 stars 7 forks source link

Fix Sonarqube scan failure "Set the SONAR_TOKEN env variable." #24

Closed haani-niyaz closed 2 years ago

haani-niyaz commented 2 years ago

The Sonarqube job appears to be failing consistently in most PRs. I don't have access to check the secret settings but I do think this only occurs when a PR is raised from a forked repo.

Example: https://github.com/rog-golang-buddies/golang-template-repository/runs/7134639006?check_suite_focus=true

haani-niyaz commented 2 years ago

An explanation and possible fix: https://github.blog/2020-08-03-github-actions-improvements-for-fork-and-pull-request-workflows/#improvements-for-public-repository-forks

haani-niyaz commented 2 years ago

Alternative manual run on inspection by maintainers: https://docs.github.com/en/actions/managing-workflow-runs/approving-workflow-runs-from-public-forks

shukra-in-spirit commented 2 years ago

I will take this up.

haani-niyaz commented 2 years ago

@shukra-in-spirit can we also rename the file to something where we can infer the workflow? build is very generic and is not representative of a code scan.