search

rog-golang-buddies / golang-template-repository

Kickstarter repository for a golang service
Apache License 2.0
17 stars 7 forks source link

V0.2.0 review updates #46

Closed haani-niyaz closed 2 years ago

haani-niyaz commented 2 years ago

Change Summary

Docs update

  1. Readme has been rewritten to access starter docs
  2. Add sample README template
  3. Fixed pre-commit docs to capture pre-commit ci integration
  4. Follow a consistent naming convention for workflow names and steps
  5. Use a lowercase file naming convention for workflows (It doesn't have to be lowercase but I picked this to keep all of them consistent)
  6. Add GoReleaser docs

Closes #44

Limit builds

Addresses #43

Dockerfile enhancements

Closes #45 .

shukra-in-spirit commented 2 years ago

Thanks, @haani-niyaz and @mridulganga for the help. @haani-niyaz have you added the comment to trigger the semantic releaser and make it v0.2.0? I am approving the PR, can you merge it if the comment message is apt. I saw that none of the other commits bumped the bug-fix versions as expected. Maybe, there is a need to encourage members to follow the commit message rules to trigger releases accordingly,

haani-niyaz commented 2 years ago

Thanks, @haani-niyaz and @mridulganga for the help. @haani-niyaz have you added the comment to trigger the semantic releaser and make it v0.2.0? I am approving the PR, can you merge it if the comment message is apt. I saw that none of the other commits bumped the bug-fix versions as expected. Maybe, there is a need to encourage members to follow the commit message rules to trigger releases accordingly,

@shukra-in-spirit, I was planning on merging #45 to this PR as it completes the v0.2.0 release requirements. Once done, I'll bump this with a feat commit to trigger v0.2.0

I saw that none of the other commits bumped the bug-fix versions as expected.

Do you mean with the fix type in the commit message or something else?

I also think some release planning is in order to keep everyone on the same page.

shukra-in-spirit commented 2 years ago

Yeap. With a fix mention in the comment to bump up the x in v0.1.x

haani-niyaz commented 2 years ago

Yeap. With a fix mention in the comment to bump up the x in v0.1.x

@shukra-in-spirit, I don't see any commits with fix type in the main branch's commit log. Possibly squashed when merging.

github-actions[bot] commented 2 years ago

:tada: This issue has been resolved in version 0.2.1 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: