search

rog-golang-buddies / golang-template-repository

Kickstarter repository for a golang service
Apache License 2.0
17 stars 7 forks source link

Update golangci-lint version #68

Closed ldmi3i closed 2 years ago

ldmi3i commented 2 years ago

It looks like golangci-lint works for the 1.18 version now. Proposing to update it in order to support 'any' and other 1.18 features. (tried this update on the https://github.com/rog-golang-buddies/api-hub_data-scraping-service/runs/7590078640?check_suite_focus=true cause it failed because of 'any')

ldmi3i commented 2 years ago

But one of the checks is probably disabled now 'structcheck is disabled because of go1.18. You can track the evolution of the go1.18 support by following the https://github.com/golangci/golangci-lint/issues/2649."', so I'm not absolutely sure about applying this update).

haani-niyaz commented 2 years ago

@ldmi3i, Thanks for raising this.

structcheck is disabled because of go1.18.

This is only a warning and rightfully so if the underlying linter does not have support.

github-actions[bot] commented 2 years ago

:tada: This PR is included in version 0.2.2 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: