search

rogaha / docker-desktop

Docker Desktop enables you to create virtual desktops that can be accessed remotely. It comes with Firefox and Libreoffice already installed!
1.15k stars 286 forks source link

Why are you setting the password this way? #1

Closed KateLibC closed 11 years ago

KateLibC commented 11 years ago

I noticed that you've set the username and password to just "docker". Why are you going about this way? This is rather insecure. I could potentially find a bunch of Docker users and just bruteforce the lot of them to get access via SSH.

rogaha commented 11 years ago

I just set it as docker a temporary password. Once you login in, you can change the password by typing: passwd in any terminal.

rogaha commented 11 years ago

@ColinKeigher Thanks for your comment. I will add to the next release a dynamic strong password creation for every time you run the container. So, each time you run it, it will give you a new secure password!

KateLibC commented 11 years ago

I am happy to hear that you're going to make changes to this script.

rogaha commented 11 years ago

Thanks @ColinKeigher I will do it during this week! Thanks again for your comments.

rogaha commented 11 years ago

The new version covers your concerns!

Thank you very much for your feedback @ColinKeigher!