search

rogaha / docker-desktop

Docker Desktop enables you to create virtual desktops that can be accessed remotely. It comes with Firefox and Libreoffice already installed!
1.15k stars 288 forks source link

README correction? #10

Closed dlintw closed 10 years ago

dlintw commented 10 years ago

I can run docker build github.com/rogaha/docker-desktop

I can NOT run docker build -t [username]/docker-desktop git://github.com/rogaha/docker-desktop.git

rogaha commented 10 years ago

Hi @dlintw,

I'm using the latest version of docker and I'm able to run:

[10:48:10 AM]% docker build -t rogaha/docker-desktop git://github.com/rogaha/docker-desktop.git

Are you replacing the [username] to your actual user name? For example for me is -t rogaha/docker-desktop

dlintw commented 10 years ago

I'm behind firewall.

docker 0.7.3

$ docker build -t dlintw/docker-desktop git://github.com/rogaha/docker-desktop.git 2014/01/14 14:35:39 Error: Error trying to use git: exit status 128 (Cloning into '/tmp/docker-build-git494265816'... fatal: unable to connect to github.com: github.com[0: 192.30.252.129]: errno=Connection refused )

dlintw commented 10 years ago

Try to use https instead of git

$docker build -t dlintw/docker-desktop https://github.com/rogaha/docker-desktop.git

# Skipping unknown instruction <!DOCTYPE
2014/01/14 14:38:05 Invalid Dockerfile format

try to use http instead of git

$docker build -t dlintw/docker-desktop http://github.com/rogaha/docker-desktop.git 

# Skipping unknown instruction <!DOCTYPE
2014/01/14 14:38:17 Invalid Dockerfile format
rogaha commented 10 years ago

It's probably a problem with your firewall permissions. Are you able to git clone https://github.com/rogaha/docker-desktop.git ?

dlintw commented 10 years ago

I use another machine which without firewall.

# docker build -t dlintw/docker-desktop git://github.com/rogaha/docker-desktop.git                 /home/dlin 7:37
2014/01/15 07:40:11 Error: Error build: archive/tar: invalid tar header
# docker version                                                                                   /home/dlin 7:37
Client version: 0.7.4
Go version (client): go1.2
Git commit (client): 010d74e
Server version: 0.7.4
Git commit (server): 010d74e
Go version (server): go1.2
Last stable version: 0.7.5, please update docker
# docker build -t dlintw/docker-desktop https://github.com/rogaha/docker-desktop.git
# Skipping unknown instruction <!DOCTYPE
2014/01/15 07:37:58 Invalid Dockerfile format
rogaha commented 10 years ago

Hi @dlintw,

The problem is with the version 0.7.4, could you please upgrade to the latest version and try it again?

Thanks

dlintw commented 10 years ago

Still failed, I just use the newest tag version 0.7.5

# docker version
Client version: 0.7.5
Go version (client): go1.2
Git commit (client): c348c04
Server version: 0.7.5
Git commit (server): c348c04
Go version (server): go1.2
#  docker build -t dlintw/docker-desktop git://github.com/rogaha/docker-desktop.git
2014/01/15 13:29:03 Error: Error trying to use git: exit status 128 (Cloning into '/tmp/docker-build-git903677109'...
fatal: unable to connect to github.com:
github.com[0: 192.30.252.131]: errno=Connection refused
)

#  docker build -t dlintw/docker-desktop https://github.com/rogaha/docker-desktop.git
# Skipping unknown instruction <!DOCTYPE
2014/01/15 13:29:15 Invalid Dockerfile format

# git clone https://github.com/rogaha/docker-desktop.git
Cloning into 'docker-desktop'...
remote: Reusing existing pack: 82, done.
remote: Total 82 (delta 0), reused 0 (delta 0)
Unpacking objects: 100% (82/82), done.
Checking connectivity... done.
rogaha commented 10 years ago

I couldn't reproduce the problem here with docker version 0.7.5. It's working for me. You can open an issue on github.com/dotcloud/docker if the problem persists.

Once you you have cloned my repo you can go to that directory and build the image with the command docker build -t dlintw/docker-desktop

Let me know how it goes.

Thanks

dlintw commented 10 years ago

May be you could append readme document as alternate method.

git clone https://github.com/rogaha/docker-desktop.git cd docker-desktop docker build -t [username]/docker-desktop .

This method workable for me.

rogaha commented 10 years ago

Good idea @dlintw, I'll do that! Thanks!

rogaha commented 10 years ago

Done! I've added that alternative way.

I'll close the issue once you successfully built it.

Thanks for your patience @dlintw

dlintw commented 10 years ago

According http://www.docker.io/learn/dockerfile/level1/ document, The correct github usage is like:

 docker build -t dlintw/docker-desktop github.com/rogaha/docker-desktop

So, may be you should correct your README.md.