rogchap / wombat

Cross platform gRPC client
MIT License
1.39k stars 52 forks source link

Prevent addresses from being restricted to TCP in order to support Unix sockets #75

Closed aschey closed 2 years ago

aschey commented 2 years ago

Including a DialContext with the protocol hardcoded as TCP was preventing the app from being able to connect to Unix socket addresses. All different address types seem to work okay without the context dialer so I think it may be fine to remove it, but if I'm missing something and it is required, then we can also parse out the URL scheme from the address and pass that to the dial context instead.