Open bkjohnson opened 10 months ago
@bkjohnson Thank you! Will take a look this weekend. Appreciate your efforts.
Thank you! Will take a look this weekend. Appreciate your efforts.
Small bump reminder in case! Hope you get time to look at this for this weekend. 🙂
Disappointed to see this close. :(
It seemed like @rogden wasn't interested, and after his work on the 2.0 release there were some merge conflicts that I wasn't motivated to deal with.
@bkjohnson Thanks for the work on this. I do think upgrading to Vue 3 is important in the mid term and appreciate the work. While I'm not certain I would ditch Koa as it is used to serve the app to the Nuxt Tailwind module, there are some other parts of this work that would make sense to incorporate. I'm happy to take over the work when I get time if you wouldn't mind leaving it open.
That's fine with me.
Vue 2 reached end of life in December, so this upgrades the package to Vue 3 following the vue CLI migration instructions. Moving to vue 3 gets us onto Vite. The priorities for this work were to keep the local npm scripts running while also making sure that the cli still worked when the package is used as a dependency.
I've also bumped the tailwind version.
To test these changes I did the following:
npm run dev
in the package and verified that the page looked fine in the browser with the sample config./cli/index.js -c tailwind.config.sample.js
to simulate using the cli when the package is installedyarn linked
to another local package to run the server and view the config in a browserexport
the viewer and served the static pages from the output directory withnpx http-serve .
Dark mode still works, and I was able to see the config values that I expected to see.