search

rogeliog / jest-runner-mocha

A Mocha runner for Jest
70 stars 12 forks source link

Use create-jest-runner. #18

Open patrickdawson opened 5 years ago

patrickdawson commented 5 years ago

Problem described in https://github.com/rogeliog/jest-runner-mocha/issues/16 bugged me to. Therefore I followed the recommendation I changed the implementation to use create-jest-worker. I hope I didn't get it wrong but all tests are running and my own problems with the original implementation are gone as well.

patrickdawson commented 5 years ago

Note quite sure why tests on node 4 are failing. I don't see how I changed something that affects expect.

ljharb commented 5 years ago

Jest aggressively drops support for older nodes, including node 4, so it probably won’t work there.

jehy commented 4 years ago

This PR looks great, may be it's time to merge this PR, drop node8- support, use latest mocha, get rid of babel and release a new major version?

Anyone who still uses old node version will still be able to use older runner branch.