search

rogeliog / jest-runner-mocha

A Mocha runner for Jest
70 stars 12 forks source link

added npm-shrinkwrap #27

Open jehy opened 4 years ago

jehy commented 4 years ago

See https://github.com/rogeliog/jest-runner-mocha/issues/26

Added shrinkwrap file - with it, you can just run npm install and npm test. Also, transitive dependencies will be respected and same fails as on tests won't happen on production.

The only drawback is that it user will have many dependencies. This is a hack which should be avoided but it is better that having code that works wrong.

jehy commented 4 years ago

Yup. But right now deps are broken. We need either to fix them or freeze them. And fixing will be really hard - and I suppose impossible if you want to keep compatibility with node 4.

ljharb commented 4 years ago

Hard or not, fixing them without breaking compat is the right thing to do.