Disable ICU for pypi - Githubissues

rogerbinns / apsw

Another Python SQLite wrapper

https://rogerbinns.github.io/apsw/

Other

744 stars 97 forks source link

Disable ICU for pypi #448

Closed rogerbinns closed 1 year ago

rogerbinns commented 1 year ago

--enable-all-extensions tries to enable ICU if the sdk is available. pypi builds currently don't detect icu so it isn't included. If it was detected it wouldn't work on deployment because of binary and abi issues.

[x] Explicitly disable ICU for pypi builds
[x] Document that
[ ] Update setup.py to use subprocess not os.popen to run icu/pkg-config to avoid running process warnings in debug

rogerbinns commented 1 year ago

Changing os.popen to subprocess requires python 3.7 for convenient options, so stuck on #471 completion

rogerbinns commented 1 year ago

Subprocess done in d22c225059d2ecd1db96ea2a96313d231984cfdd