fix: write after rotateStream destroyed

rogerc / file-stream-rotator

NodeJS file stream rotator

MIT License

143 stars 69 forks source link

fix: write after rotateStream destroyed #73

Open SunshowerC opened 4 years ago

SunshowerC commented 4 years ago

should not write when rotateStream has been destroyed. It would fix this bug: https://github.com/winstonjs/winston-daily-rotate-file/issues/226

privateOmega commented 3 years ago

@rogerc Could you PTAL?

rogerc commented 2 years ago

@SunshowerC thanks for the PR, however this seems to be an issue with process specific logging rather than routing all logging through the parent process. Just silencing the error is not really a good fix. Silencing the error discarding the data that should be logged and not deal with the root cause is not what users would expect.