rogerclarkmelbourne / Arduino_STM32

Arduino STM32. Hardware files to support STM32 boards, on Arduino IDE 1.8.x including LeafLabs Maple and other generic STM32F103 boards
Other
2.52k stars 1.26k forks source link

Add GD32F103CB board support #820

Closed stefkpl closed 3 years ago

stefkpl commented 3 years ago

For use with 12Mhz crystal @96Mhz and USB serial.

rogerclarkmelbourne commented 3 years ago

This repo originally included GD32 support, but the GD32 chip is not 100% compatible with the STM32 chip. Your PR just uses the variant folder that already exists.

People reported problems with SPI and other interfaces not working on the GD32 the same as on the STM32.

So I had to remove the GD32 from the list of available boards.

I retained the GD32 variant folder, so that people like you, who want to modify the repo can try the GD32 variant, however because the GD32 is not 100% compatible with the STM32 I can't accept this PR, as other people will try to use the GD32 and raise bugs because of the incompatibility.

BTW. There was a big list of incompatibilities and differences posted on a Russian web site, but that was several years ago, so the post may no longer exist.

stefkpl commented 3 years ago

Ok I understand, thanks. Good job :)