search

rogerclarkmelbourne / Arduino_STM32

Arduino STM32. Hardware files to support STM32 boards, on Arduino IDE 1.8.x including LeafLabs Maple and other generic STM32F103 boards
Other
2.52k stars 1.26k forks source link

Fix "unknown type uint8_t" error #825

Closed Craft4Cube closed 3 years ago

Craft4Cube commented 3 years ago

Added missing include to "inttypes.h"

rogerclarkmelbourne commented 3 years ago

Can you list the steps to reproduce the error

GitMoDu commented 3 years ago

Why not just #include where needed?

ArminJo commented 3 years ago

@rogerclarkmelbourne Please merge it fast, You can see errors here and here and more here It crashes all my CI Workflows using your core! I do not want to skip support for your core!

ArminJo commented 3 years ago

And please consider to release it fast, since all my compiles crashes.

stevstrong commented 3 years ago

@ArminJo , the best solution is to change in line 34

uint8_t negative = 0;

to 

unsigned char negative = 0;

Please change this in you PR and then I will commit it. And then remove the extra include line, it is not needed anymore.

ArminJo commented 3 years ago

@stevstrong I totally agree, but the PR is not from me. But of course I can provide a new PR for this, if it helps, but maybe it is easier to just change the line manually and then close this PR? And thanks for the fast reply! 👍

stevstrong commented 3 years ago

This should be fixed by https://github.com/rogerclarkmelbourne/Arduino_STM32/commit/194a45ae256c6ede786d58525fe1b7550c9e6614.

ArminJo commented 3 years ago

T H A N K S 👍