Adafruit_ILI9341_STM (stm32f1): Compatibility with current HEAD versions of Adafruit GFX

rogerclarkmelbourne / Arduino_STM32

Arduino STM32. Hardware files to support STM32 boards, on Arduino IDE 1.8.x including LeafLabs Maple and other generic STM32F103 boards

Other

2.52k stars 1.26k forks source link

Adafruit_ILI9341_STM (stm32f1): Compatibility with current HEAD versions of Adafruit GFX #829

Closed kiki-lamb closed 10 months ago

kiki-lamb commented 3 years ago

The ILI9341 has depended on a fairly ancient (1.5.3) version of the Adafruit GFX Library.

This commit makes it compatible with the current HEAD versions of the Adafruit GFX Library by making the following two changes:

Update references to use textsize_x (renamed in version 1.5.4 of the graphics library) when calculating positions/sizes in Adafruit_GFX_AS.cpp.
Provides the SPIClass::transfer(...) method expected by Adafruit BusIO's SPIDevice class.

stevstrong commented 3 years ago

While changing all occurrences is one way to solve the issue, wouldn't be nicer to use #define textsize textsize_x before the first occurrence?

kiki-lamb commented 3 years ago

I think whether a #define would be 'nicer' is sort of a toss-up: it's more concise, but on the other hand it's one more macro to remember. If you'd prefer to solve it that way I'll happily concede, though.

stevstrong commented 10 months ago

It is not a clean solution but I will merge this though. If anyone needs more transfer functions for SPI, then I would recommend to use my repo.