rogerclarkmelbourne / Arduino_STM32

Arduino STM32. Hardware files to support STM32 boards, on Arduino IDE 1.8.x including LeafLabs Maple and other generic STM32F103 boards
Other
2.53k stars 1.26k forks source link

Fix dfu_util upload #846

Closed vinzenz closed 11 months ago

vinzenz commented 3 years ago

"{runtime.ide.path}" was appended to the dfu-util call which is nonsense

stevstrong commented 3 years ago

It is not non-sense, it was specially added to solve issue #813 . Do you have any problem with that?

vinzenz commented 3 years ago

OK I see, so the problem is that the fifth parameter in the macos tool is used for dfuse-address => https://github.com/dadul96/Arduino_STM32/blob/c9ab50d6b7c60c75f6ca5948122e1e76cb625b01/tools/macosx/maple_upload#L37

Which caused me headaches uploading

vinzenz commented 3 years ago

Same in Linux64: https://github.com/dadul96/Arduino_STM32/blob/c9ab50d6b7c60c75f6ca5948122e1e76cb625b01/tools/linux64/maple_upload#L13

and Linux: https://github.com/dadul96/Arduino_STM32/blob/c9ab50d6b7c60c75f6ca5948122e1e76cb625b01/tools/linux/maple_upload#L13

So the solution to this would be to change it to parameter 6 and have 5 empty, i guess

stevstrong commented 3 years ago

I think the number in "if" condition should be changed to 6:

if [ $# -eq 6 ]; then
    dfuse_addr="--dfuse-address $6"
stevstrong commented 11 months ago

@vinzenz this PR in this state does not solve anything. Do you want to make some updates?

vinzenz commented 11 months ago

Hi, TBH I don't even remember what this was about exactly and have moved on since. So I just closed it