random() without parameter like in standard Arduino API is missing.

[ArminJo]

Standard Arduino programs do not compile if they userandom();

E.g.

/home/runner/Arduino/libraries/NeoPatterns/src/NeoPatterns.hpp:1474:31: error: no matching function for call to 'random()'
         tRandom.Long = random();
                               ^
/home/runner/Arduino/libraries/NeoPatterns/src/NeoPatterns.hpp:1474:31: note: candidates are:
...
/home/runner/.arduino15/packages/stm32duino/hardware/STM32F1/2021.5.31/cores/maple/wirish_math.h:50:6: note: long int random(long int)
 long random(long max);

if I replace the line 50 in wirish_math.h long random(long max); with long random(long max = __LONG_MAX__); everything works fine.

Do you require a PR?

[rogerclarkmelbourne]

Where is random() implemented ?

[ArminJo]

??? long random(long howbig= __LONG_MAX__); introduces a default/optional parameter.

long random(long howbig) is implemented here

[rogerclarkmelbourne]

Create a PR and I will merge it, as I think its a low risk change

[ArminJo]

Done!

[rogerclarkmelbourne]

Thanks

[ArminJo]

Thank YOU for maintaining this core 🥇 .

[ArminJo]

@stevestrong @rogerclarkmelbourne Is there any reason, why the PR is not merged now?

[stevstrong]

which PR?

[ArminJo]

Sorry I had "Tomaten auf den Augen". it was PR https://github.com/rogerclarkmelbourne/Arduino_STM32/pull/889. I was searching for it in order to delete my local fork and I have not found it, since I looked at the wrong place. Thanks again for maintaining!