rogerdudler / eclipse-ui-themes

Dark UI Theme for Eclipse 4+
http://rogerdudler.github.com/eclipse-ui-themes/
Eclipse Public License 1.0
319 stars 106 forks source link

Multipage Editor (XML) loosing its tabs. #11

Open ghost opened 12 years ago

ghost commented 12 years ago

In the themes available by default, everything's fine. The tabs at the bottom of the editor are visible.

before applying Dark Juno

And once the the Dark Juno theme is applied, those tabs at the bottom of the editor disappear.

after applying Dark Juno

ahcox commented 11 years ago

I see this too on Ubuntu 12.10 (before it is released), Eclipse 4.2 (Juno).

http://stackoverflow.com/questions/12534818/how-do-i-force-eclipse-to-show-xml-layouts-and-styles-as-text

eclipse dumps this on startup:

~$ eclipse
Failed to find defStyle: listViewStyle
Failed to find defStyle: listViewStyle
Failed to find defStyle: listViewStyle
Failed to find defStyle: textViewStyle
Failed to find defStyle: textViewStyle
Failed to find defStyle: textViewStyle
Failed to find defStyle: buttonStyle
Failed to find defStyle: buttonStyle
Failed to find defStyle: buttonStyle
Failed to find defStyle: buttonStyle
Failed to find defStyle: buttonStyle
Failed to find defStyle: buttonStyle
Failed to find defStyle: buttonStyle
Failed to find defStyle: buttonStyle
Failed to find defStyle: buttonStyle
emilio-simoes commented 11 years ago

I'm having this issue to both on Windows 7 x64 and Kubuntu 12.04 x64 with Eclipse Juno.

ghost commented 11 years ago

@ahcox @emilio-simoes Yeah! No idea what @rogerdudler is upto with this.

rogerdudler commented 11 years ago

I actually don't know what the problem is on that one. I think it's a general theming problem. I have to get in touch with the core team to fix this.

ghost commented 11 years ago

Good luck @rogerdudler. We love your work, and wish to see the result soon. :+1:

ahcox commented 11 years ago

@iontech @rogerdudler, Yeah to what iontech said. I am still using the theme and like it very much. I wrote up my steps to getting a fully dark Eclipse Juno on Ubuntu here: http://www.hoogli.com/items/Light_on_Dark_Eclipse_4.2_(Juno)_Themes.html

It is possible to switch tabs with ALT-PgUp & ALT-PgDn even though you can't see the GUI elements, which is faster and saves screen real estate. So this is actually a feature in my book ;-).

I am very happy with the result: http://hoogli.com.nyud.net/img/dark_eclipse_juno_theme_003.png

Thanks Roger!

elbowz commented 11 years ago

any news? I have the same problem on Kubuntu 12.10

ghost commented 11 years ago

@elbowz Nope. No update. Still waiting. @rogerdudler and his team might be real busy with other stuff. Hope to get a patch soon.

rogerdudler commented 11 years ago

I am indeed... If someone of you can help out, I would really appreciate it.

ghost commented 11 years ago

@rogerdudler try removing the line: swt-tab-renderer: url(bundleclass://org.eclipse.e4.ui.workbench.renderers.swt/org.eclipse.e4.ui.workbench.renderers.swt.CTabRendering);

from the CTabFolder element

ghost commented 11 years ago

you should get something like http://snag.gy/T9TQD.jpg

rogerdudler commented 11 years ago

@scela are you able to create a pull request for that?

ghost commented 11 years ago

https://github.com/rogerdudler/eclipse-ui-themes/pull/16

also more details will follow on https://bugs.eclipse.org/bugs/show_bug.cgi?id=396780

rogerdudler commented 11 years ago

@scela Thanks!!

elbowz commented 11 years ago

@scela yeah, now work good! Thanks!

ghost commented 11 years ago

Great.

On Tue, Dec 18, 2012 at 9:18 AM, elbowz notifications@github.com wrote:

@scela https://github.com/scela yeah, now work good! Thanks!

— Reply to this email directly or view it on GitHubhttps://github.com/rogerdudler/eclipse-ui-themes/issues/11#issuecomment-11477428.

DJViking commented 11 years ago

The tabs are again visible, but something else got worse.

The color theme got pitch black. Before it was a grayish black. Because of this the buttons for dropdownlist, minimize and maximize are invisible. They are there black on black.

How it looks like on a light theme. eclipse-screenshot13

How it now looks with the modified Juno Dark. eclipse-screenshot14

How it previosuly looked with Juno Dark. eclipse-screenshot15

I have no problem with pitch black, but other elements on it cannot be black or they will become invisible.

Edit: Not sure why it becomes pitch black. Any changes I do to the juno.css file, repackage it and it becomes pitch black. Even just changing .MPartStack font-size to 10 from the previous Juno Dark makes it pitch black background.

ghost commented 11 years ago

I'm not sure my PR caused this because it has no relation to pitch or no pitch black colors, at least directly.

DJViking commented 11 years ago

You're right. It was my attempt to repackage the jar file that was the problem. Repackage created a new MANIFEST file. After repackaging I copied the original MANIFEST file and it worked.