[Android Bootcamp] Review my app

[rogerhu]

/cc @nesquena @timothy1ee

Got the share working now...still ironing out a few bugs. But should be good enough to go. :)

[nesquena]

Roger, :+1: excellent submission. A few notes after checking out the code:

• Good to see you got infinite scrolling working with the endless listener
• Clean handling of QueryParameters in SearchActivity
• Cool approach for your settings page creating a ListView and a custom adapter for rendering the different spinners. I actually haven't seen this approach before (everyone normally just adds the spinners to the layout manually) but I think it's really interesting. What was your reasoning for creating the ListView of spinners? I like the abstractions it provides.
• Nice to see how you handled the updateSettings method and pass the array of QueryParameter

Really nice job. For reference, here's provided a more detailed Project 2 Feedback Guide here which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you could improve your submission.

Let us know if you have any other thoughts or questions about this assignment. The next assignment (Twitter Client) will be especially important since it introduces the majority of the remaining pieces necessary to build a fully functional API client with complex feeds of data and user creation.

[rogerhu]

Yeah I was starting at the Google Image Search API and thought there were a bunch of ones that could be added beyond the ones you spec'd out...hence my internal decision about whether we should be creating things programatically or manually.

This was a pretty hefty assignment...thanks for the fast code review!

[nesquena]

This was a pretty hefty assignment...thanks for the fast code review!

Ha, yes it was a substantial assignment which I tried to warn people about. Hopefully you found it helpful as we start to put all the pieces of Android development together.