search

rogerluan / app-store-connect-notifier

Node.js app that sends App Store Connect notifications to Slack.
BSD 2-Clause "Simplified" License
102 stars 23 forks source link

Add the ability to post messages using slack webhook #142

Closed tahirmt closed 3 years ago

tahirmt commented 3 years ago

In order to avoid creating a bot account with chat permissions, we can alternatively just use Incoming Webhooks. This is better because this way the bot account doesn't have permissions to post to more than one channel.

tahirmt commented 3 years ago

@rogerluan I know we still need to create a slack bot account but this way the bot account has far fewer permissions requirement but the end result is the same. Which is why we opted to use incoming Webhooks. I can definitely mark the other parameters optional. I wanted to open a PR before I did that because I noticed the ITC_USERNAME is a required field but you can alternatively set the App Store connect api key SPACESHIP_CONNECT_API_ISSUER_ID, SPACESHIP_CONNECT_API_KEY_ID and SPACESHIP_CONNECT_API_KEY and not set the iTunes connect credentials at all and still get everything to work. Perhaps we should document that as well.

tahirmt commented 3 years ago

That will be a separate PR of course.

rogerluan commented 3 years ago

Yep, I get the reasoning behind the usage of webhooks, that was a great find of yours! 🎉 Good spotting on the ITC_USERNAME as well! Yeah we'll need to fix that part of the documentation as well 😬 (in a separate PR would be great)