search

rogerluan / app-store-connect-notifier

Node.js app that sends App Store Connect notifications to Slack.
BSD 2-Clause "Simplified" License
102 stars 23 forks source link

Add ability to track Testflight status notifications #268

Open DrDraxi opened 1 year ago

DrDraxi commented 1 year ago

Hi. It would be nice to track Testflight processing + beta review statuses. I was trying to look into Spaceship and your code and got a bit lost when trying to figure it out.

rogerluan commented 1 year ago

Hi @DrDraxi 👋

Thanks for your suggestion! I'll take it into consideration when implementing improvements to this project 🤗

For now, I can't promise this feature will be added any time soon. But I'll keep you posted should this change in the near future! 🙏

rogerluan commented 1 year ago

@DrDraxi also, could you clarify what you mean by TF processing + beta review statuses? Would it be this feature? ⬇️

image

(plus the "processing" status prior to this "valid" one)

DrDraxi commented 1 year ago

@rogerluan hi, thanks for your response. That is exactly what I meant by that. Testflight has Processing status after you upload the ipa.

After it finishes processing it has the status of Missing Compliance where you need to select what data encryption the app uses. I think there is a way to have it automatically set itself.

Then it can be tested by Internal testers with the status Ready to submit. Meaning ready to submit for review for external testing.

Then it goes Waiting for review -> In review -> Testing (by the external testers)

After 90 days or if you revoke the build expires with status Expired

Honestly statuses when it finishes processing and when it gets approved for testing would be more than enough. Thank you for this amazing project btw. 😄

rogerluan commented 1 year ago

I'm glad you enjoy this project @DrDraxi 🤗

I see you mentioned the "missing compliance" step - not sure you know about this but you can set a key-value in your Info.plist so that your app doesn't enter the Missing Compliance step anymore: https://stackoverflow.com/a/35842359/4075379 this might be helpful to you 😊 it essentially automates the data encryption selection step for you (works for the majority of the apps that have simple encryption logic).

I think this would be a good opportunity for me to share with you that I've been working on statused.com, a project of mine that aims to make app-store-connect-notifier consumable by 'anyone' (and not just developers). It's also the only place where I'll be implementing new features. But don't worry, I intend to keep app-store-connect-notifier open source 😉

With that being said, you can achieve the outcome that you want (just 'processing' and 'ready to test') via Build Status: https://github.com/rogerluan/app-store-connect-notifier#build-status, where "VALID" status means "ready to test by internal testers in TestFlight" (essentially, the screenshot I sent in my message above).

I hope this helps! And if you're interested in my project Statused, don't forget to sign up for early access! 💪