rogerluan / arkana

Use dotenv files for Android and iOS projects.

BSD 2-Clause "Simplified" License

374 stars 18 forks source link

Required Ruby version #14

Closed kszczepanskidev closed 2 years ago

kszczepanskidev commented 2 years ago

Hello, I've noticed that this tool require ruby 2.7+, but by default MacOS and bitrise's Xcode stack are using 2.6.x. It's not a big issue to bump it, but for most developers that don't dabble with ruby it will be additional stepping stone while adding Arkana to their projects. Would it be possible to lower requirement?

rogerluan commented 2 years ago

Hi @krysztalzg 👋 thanks for this feedback! I think it wouldn't be too much of a big lift to lower the requirement to 2.6.x - IIRC I am using some set of APIs only available in v2.7.x but I can't recall which ones from the top of my head, so I'd need to test this out. Do you happen to know which specific Ruby version macOS and Bitrise comes with, or should we just attempt to add support to v2.6.0?

Also, would this be something you'd be willing to contribute by opening a PR for? 😊

andestaerfan commented 2 years ago

I have the same issue on Bitrise. Any help on this? @krysztalzg @rogerluan

rogerluan commented 2 years ago

@erfanandesta1373 I haven't removed v1.1.1 or any other version from RubyGems 🤔 is your issue related to the ruby version?

andestaerfan commented 2 years ago

Actually, the problem is what @krysztalzg explained. Bitrise uses 2.6.9 as it's the latest Xcode ruby installed. I just change the minimum version to 2.6.9 on this PR and it's working fine.

rogerluan commented 2 years ago

15 was merged!

I'm going to release it asap.

rogerluan commented 2 years ago

Released! https://github.com/rogerluan/arkana/releases/tag/v1.2.0 😉

@krysztalzg @erfanandesta1373 let me know if there are any issues after upgrading to v1.2.0! 💪

Closing this ticket.