search

rogerluan / arkana

Use dotenv files for Android and iOS projects.
BSD 2-Clause "Simplified" License
362 stars 18 forks source link

Add ability to disable cross import of modules #35

Closed jdanthinne closed 1 year ago

jdanthinne commented 1 year ago

This PR adds to ability to remove the import ArkanaKeysInterfaces statement in ArkanaKeys module when used with Cocoapods.

As I'm building an SDK using Arkana, importing via Pods, so I'm importing the Sources folder directly and this import statement was causing a compilation error, because all Sources are in the same module.

jdanthinne commented 1 year ago

For the unit test, as it is a preprocessor thing, it is hard to write that in the Swift tests. I guess it should be a Ruby unit test, but I must admit I don't know how it's done (I'm mainly an iOS dev).

jdanthinne commented 1 year ago

Please don't make a release with this change too soon. I think I've come across a strange case where this doesn't work as planed.

rogerluan commented 1 year ago

😬 got it! Thank you for the heads up. What is the issue?

rogerluan commented 1 year ago

@jdanthinne any update? Otherwise I'll revert this PR 🙏 please let me know.

jdanthinne commented 1 year ago

Sorry for the delay. It seems that in some configuration, my conditional compilation doesn't work as expected. I'll try to get back to you asap.

jdanthinne commented 1 year ago

Nevermind, it seems to work fine, finally. I guess Xcode was lost when I was switching back and forth when I was changing the code between Cocopoads and SPM usage. I re-tried everything today, and it's ok.

rogerluan commented 1 year ago

Sounds good. Thank you @jdanthinne 👍