rogerluan / arkana

Use dotenv files for Android and iOS projects.
BSD 2-Clause "Simplified" License
362 stars 18 forks source link

Fix regression related to `require_relative` and fix integration tests #65

Closed rogerluan closed 1 month ago

rogerluan commented 1 month ago

Description

This PR fixes #64 which was caused by #56 and introduced in v2.1.0

Even though I identified what was causing the issue, I wanted to fix the integration tests so that these type of incidents don't happen again. Took me awhile to figure out what was causing this to only fail when installing specifically using Bundler, but issue was that in the old [broken] integration tests, we were installing the gem at the root folder of this project, which caused some coincidences in the filepaths to make require_relative to work, but once we changed the installation path, they stopped working.

This was proven by first committing only the changes that make the tests fail:

image

And then committing the fix:

image