search

rogersanick / SettlersOfCordan

Other
11 stars 4 forks source link

Making use of the new board classes to simplify flows #27

Closed xavierlepretre closed 5 years ago

xavierlepretre commented 5 years ago

@rogersanick I reckon we could merge this now.

xavierlepretre commented 5 years ago

I will split the GameBoardState.kt file into smaller chunks after this merge.

xavierlepretre commented 5 years ago

I have 2 failed tests. 

java.lang.AssertionError: You should be using the end turn function. Expected an exception of class net.corda.core.flows.FlowException to be thrown, but was java.lang.IllegalArgumentException: You cannot build a new road on top of a current one

Which is thrown by a require in a class in game board. I could not pinpoint where the road is attempted to be overwritten.

The other is because of a assert(false)...

xavierlepretre commented 5 years ago

Otherwise good to merge.