search

rogersanick / SettlersOfCordan

Other
11 stars 4 forks source link

Bringing some readability to prices and flows #31

Closed xavierlepretre closed 5 years ago

xavierlepretre commented 5 years ago

@rogersanick What do you think?

xavierlepretre commented 5 years ago

@rogersanick A lot of work to get the flows more straightforward. Let's hope it does not cause too many conflicts with others...

xavierlepretre commented 5 years ago

The unit tests of states all pass. As for the flows, you have to change to MutableList, which I can add, for them to not be stuck on deserialisation.

xavierlepretre commented 5 years ago

I think you should merge Gonzalo's first. I will fix the conflicts on mine.

rogersanick commented 5 years ago

Merged @abellagonzalo s branch. Once you've fixed the conflicts I'll merge this PR as well. See you both tomorrow at CCC!

xavierlepretre commented 5 years ago

That was fast!