search

rogershen / chrome-regex-search

Other
267 stars 56 forks source link

Please add support for searching in iframes #20

Closed xlerebux closed 5 years ago

xlerebux commented 6 years ago

Some sites use iframes to show main content, but searching inside them not possible. It will be very useful if your extension will support searching text in iframes. Will you plan to add this functionality?

brandon1024 commented 6 years ago

@xlerebux @rogershen Although it is possible using the standard JavaScript API to get the document object from an iframe (using element.contentDocument), due to security reasons it is only possible to search within iframes where the source is within the same domain.

So it wouldn't be possible to make this feature work for all cases. This would introduce an apparent buggy feel to the extension.

rogershen commented 5 years ago

Brandom is right. iframes make the extension very wonky. There are no plans to add this feature as I don't really know how to implement it. I would love to take a pull request if you can figure it out.