search

rogershen / chrome-regex-search

Other
267 stars 56 forks source link

Text in Unicode bold/italics/etc is not recognized by the search #30

Open mgttlinger opened 6 years ago

mgttlinger commented 6 years ago

If you try to search for test here then only the regular variant will be found. The normal search of Chrome handles this case as one would expect.

regular: test bold serif: 𝐭𝐞𝐬𝐭 bold sans: 𝘁𝗲𝘀𝘁 italics serif: 𝑡𝑒𝑠𝑡 italics sans: 𝘵𝘦𝘴𝘵 bold italic serif: 𝒕𝒆𝒔𝒕 bold italic sans: 𝙩𝙚𝙨𝙩

7fe commented 5 years ago

please fix this sub and sup don't work either

mtoconno commented 5 years ago

Unicode works for me in Chrome

skeets23 commented 5 years ago

@mtoconno - you're saying when you use this extension on this page to search "test", it gets all 8 instances in the top post here?

rogershen commented 5 years ago

Yes, I can confirm this is a problem. If you try to search using 'test' it doesn't work, but if you copy the unicode directly (𝒕𝒆𝒔𝒕) it works. Being able to search both the raw string and the unicode version definitely complicates things and I admittedly don't really know how to solve it in an efficient way. I found this article on the topic: https://mathiasbynens.be/notes/javascript-unicode. If you guys can find a good solution, I would be happy to take a pull request.