search

rogershen / chrome-regex-search

Other
267 stars 56 forks source link

Doesn't seem to search within frames #51

Open RichardBronosky opened 3 years ago

RichardBronosky commented 3 years ago

My main reason for wanting this is to search for things in the AWS console. Unfortunately, CloudWatch Logs (and many others) use iframes. Is there a security limitation that would prevent you from accessing frames?

benrifkah commented 2 years ago

Since frames are deprecated I'm not expecting a fix for this to be a priority, but I can confirm this behavior and provide a minimal test case.

Steps to reproduce:

  1. navigate to this frameset demo page: https://www.w3resource.com/html/frameset/html-frameset-tag-example.html
  2. search for any text in any of the frames with the Chrome Regex Search extension; e.g.: "THIS IS PAGE ONE"
  3. Observe that the extension indicates that there are zero matches as shown in this screenshot:

Screenshot of a browser displaying the frameset demo page. Items are underlined in red: address bar showing the demo page url; the open extension input with the text "THIS IS PAGE ONE" entered which also indicates "0 of 0"; the matching text in the first frame which is not highlighted.

Expected results:

  1. The matching text in the page should be highlighted
  2. the extension should show the number of matches.

E.g.: when "THIS IS PAGE ONE" is entered, the text in the first frame should be highlighted and the extension should shows that it is highlighting the first of 1 match.

vinismarques commented 1 year ago

Would be great to have support for frames. I could not find any extension that does that.